emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Question about PRIMARY saved-region-selection


From: Petr Hracek
Subject: Question about PRIMARY saved-region-selection
Date: Wed, 27 May 2015 12:00:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

Hi folks,

I saw that you have fixed the bug with PRIMARY issue.
Is this bug also relevant for emacs-24.3 or only for 24.4?

$ git show c3c4b758c6d3e33d7fa7621ba4a50ec75c121247
commit c3c4b758c6d3e33d7fa7621ba4a50ec75c121247
Author: Jan D <address@hidden>
Date:   Sun Mar 22 19:31:46 2015 +0100

    Fixes: debbugs:18939

    * simple.el (deactivate-mark): Only modify PRIMARY if we own PRIMARY.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 8f888e3..7c7c66d 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-22  Jan Djärv  <address@hidden>
+
+       * simple.el (deactivate-mark): Only modify PRIMARY if we own
+       PRIMARY (Bug#18939).
+
 2015-03-22  Martin Rudalics  <address@hidden>

        * emacs-lisp/debug.el (debug): Don't try using "previous" window
diff --git a/lisp/simple.el b/lisp/simple.el
index ae07f62..5e5cd87 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -4420,7 +4420,8 @@ run `deactivate-mark-hook'."
       ;; the region prior to the last command modifying the buffer.
       ;; Set the selection to that, or to the current region.
       (cond (saved-region-selection
-            (x-set-selection 'PRIMARY saved-region-selection)
+            (if (x-selection-owner-p 'PRIMARY)
+                (x-set-selection 'PRIMARY saved-region-selection))
             (setq saved-region-selection nil))
            ;; If another program has acquired the selection, region
            ;; deactivation should not clobber it (Bug#11772).
$


Greetings and thank you in advance

-- 
Petr Hracek
Software Engineer
Developer Experience
Red Hat, Inc
Mob: +420777056169
email: address@hidden

-- 
Petr Hracek
Software Engineer
Developer Experience
Red Hat, Inc
Mob: +420777056169
email: address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]