[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which h
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior |
Date: |
Tue, 05 May 2015 13:48:08 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> It is always a marker, isn't it?
I think so, yes.
> Some other parts of simple.el assume it always returns non-nil.
> I'll remove the nil check.
Good, thanks.
>> IIUC activate-mark-hook should also be run when (eq omark nmark) but
>> cur-mark-active was nil.
> Huh. I just mechanically translated the original save-excursion C code.
Ah, you're probably right: the save-excursion code had such kinds of problems.
> I'll change the code to match the comment.
Thanks,
Stefan