[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-back
From: |
vibhavp |
Subject: |
Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char. |
Date: |
Fri, 20 Mar 2015 00:18:19 +0530 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>> * lisp/leim/quail/hangul.el
>> * lisp/progmodes/cperl-mode.el: Use delete-char instead of
>> delete-backward-char, fixes compilation warnings.
>
> The above doesn't use the right syntax. The right syntax looks like
>
> * <filename> (<functionname>): blabla.
>
> IOW you need to add the function names.
> Please re-read
> https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
>
>> @@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify'
>> is non-nil."
>> (delete-region (point) p))
>> (if cperl-electric-backspace-untabify
>> (backward-delete-char-untabify arg)
>> - (delete-backward-char arg)))))
>> + (delete-char (- arg))))))
>
> This doesn't look right: I think here we do want to run
> delete-backward-char since this is part of a command which basically
> extends the normal binding of DEL which is delete-backward-char.
> Maybe we should call it interactively, tho.
>
>
> Stefan
Attached patch. Does this look good?
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 74a0988..af0a0ad 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-19 Vibhav Pant <address@hidden>
+
+ * lisp/progmodes/cperl-mode.el (cperl-electric-backspace):
+ Call delete-backward-space interactively instead of delete-char.
+
2015-03-19 Stefan Monnier <address@hidden>
* emacs-lisp/eieio.el (object-slots): Return slot names as before
@@ -60,8 +65,10 @@
2015-03-19 Vibhav Pant <address@hidden>
- * lisp/leim/quail/hangul.el
- * lisp/progmodes/cperl-mode.el: Use delete-char instead of
+ * lisp/leim/quail/hangul.el (hangul-delete-backward-char)
+ (hangul-to-hanja-conversion):
+ * lisp/progmodes/cperl-mode.el (cperl-electric-keyword)
+ (cperl-electric-backspace): Use delete-char instead of
delete-backward-char, fixes compilation warnings.
2015-03-18 Michael Albinus <address@hidden>
diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el
index f207016..2acfc10 100644
--- a/lisp/progmodes/cperl-mode.el
+++ b/lisp/progmodes/cperl-mode.el
@@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify' is
non-nil."
(delete-region (point) p))
(if cperl-electric-backspace-untabify
(backward-delete-char-untabify arg)
- (delete-char (- arg))))))
+ (call-interactively 'delete-backward-char)))))
(put 'cperl-electric-backspace 'delete-selection 'supersede)
--
Vibhav Pant
address@hidden