Re: [PATCH] - Introduce reference to a new Emacs build target - NaCl

[Pete Williamson]

Yes, that's intentional, I wanted to vet the approach first.  If others feel the same, I'm happy to move all the changes into my patch.
On Mar 13, 2015 4:44 PM, "Michal Nazarewicz" <address@hidden> wrote:
>
> On Fri, Mar 13 2015, Pete Williamson <address@hidden> wrote:
> > @@ -8206,6 +8210,7 @@ rm -f core conftest.err conftest.$ac_objext \
> >
> > test "x$CANNOT_DUMP" = "x" && CANNOT_DUMP=no
> > case "$opsys" in
> > + nacl) CANNOT_DUMP=yes ;;
> > your-opsys-here) CANNOT_DUMP=yes ;;
> > esac
> >
> > @@ -9828,6 +9833,7 @@ system_malloc=no
> > case "$opsys" in
> > ## darwin ld insists on the use of malloc routines in the System framework.
> > darwin|sol2-10) system_malloc=yes ;;
> > + nacl) system_malloc=yes ;;
> > esac
> >
> > if test "${system_malloc}" = "yes"; then
> > @@ -15169,7 +15175,7 @@ esac
> > emacs_broken_SIGIO=no
> >
> > case $opsys in
> > - hpux* | irix6-5 | openbsd | sol2* | unixware )
> > + hpux* | irix6-5 | openbsd | sol2* | unixware | nacl )
> > emacs_broken_SIGIO=yes
> > ;;
> >
> > @@ -15277,7 +15283,7 @@ case $opsys in
> >
> > ;;
> >
> > - gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> > + nacl | gnu-linux | gnu-kfreebsd | freebsd | netbsd )
> > if test "x$ac_cv_func_grantpt" = xyes; then
> >
> > $as_echo "#define UNIX98_PTYS 1" >>confdefs.h
> > @@ -15430,7 +15436,7 @@ if test $emacs_glibc = yes; then
> > emacs_pending_output=unknown
> >
> > case $opsys in
> > - gnu | gnu-linux | gnu-kfreebsd )
> > + nacl | gnu | gnu-linux | gnu-kfreebsd )
> > { $as_echo "$as_me:${as_lineno-$LINENO}: checking for style of pending
> > output formalism" >&5
> > $as_echo_n "checking for style of pending output formalism... " >&6; }
> > cat confdefs.h - <<_ACEOF >conftest.$ac_ext
> > @@ -24659,7 +24665,7 @@ LD_FIRSTFLAG=
> > ORDINARY_LINK=
> > case "$opsys" in
> > ## gnu: GNU needs its own crt0.
> > - aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware) ORDINARY_LINK=yes
> > ;;
> > + nacl|aix4-2|cygwin|darwin|gnu|hpux*|irix6-5|sol2*|unixware)
> > ORDINARY_LINK=yes ;;
>
> So your patch, the attached file, is missing the above changes in the
> configure.ac file.  Is that intentional?  I imagine it would make sense
> to bundle them all together into a single patch.
>
> --
> Best regards,                                         _     _
> .o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
> ..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
> ooo +--<address@hidden>--<xmpp:address@hidden>--ooO--(_)--Ooo--