Re: Minor Patch: Respect browse-url-new-window-flag

[T.V Raman]

That's an "interesting" read.

I'm probably more the exception than the rule in that I browse
the Web more in Emacs than outside it. 

For my particular use case, I'll go ahead and solve the problem
via an advice.

Lars Magne Ingebrigtsen writes:
 > "T. V. Raman" <address@hidden> writes:
 > 
 > > Here is a simple patch to eww.el to respect option
 > > browse-url-new-window-flag
 > > git diff master -- eww.el
 > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el
 > > index 2059b5e..4613b4c 100644
 > > --- a/lisp/net/eww.el
 > > +++ b/lisp/net/eww.el
 > > @@ -680,7 +680,7 @@ the like."
 > >
 > >  ;;;###autoload
 > >  (defun eww-browse-url (url &optional new-window)
 > > -  (cond (new-window
 > > +  (cond ((or browse-url-new-window-flagnew-window)
 > 
 > I don't think that's appropriate.  browse-url says whether to open a new
 > window when you're opening an URL outside of a browser, not what the
 > browser should do once you've opened it.
 > 
 > -- 
 > (domestic pets only, the antidote for overdose, milk.)
 >    bloggy blog: http://lars.ingebrigtsen.no