emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Is `gnutls-negotiate' missing a `copy-sequence'?


From: Mario Lang
Subject: Is `gnutls-negotiate' missing a `copy-sequence'?
Date: Tue, 01 Jul 2014 17:42:24 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.91 (gnu/linux)

Hi.

Just noticed this piece of code in `gnutls-negotiate':

         (verify-error (or verify-error
                           ;; this uses the value of `gnutls-verify-error'
                           (cond
                            ;; if t, pass it on
                            ((eq gnutls-verify-error t)
                             t)
                            ;; if a list, look for hostname matches
                            ((listp gnutls-verify-error)
                             (cl-mapcan
                              (lambda (check)
                                (when (string-match (car check) hostname)
                                  (cdr check)))
                              gnutls-verify-error))
                            ;; else it's nil
                            (t nil))))

Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
destructively modify it.  Am I missing something, or should we add a
`copy-sequence' around the `cdr'?

-- 
CYa,
  ⡍⠁⠗⠊⠕



reply via email to

[Prev in Thread] Current Thread [Next in Thread]