emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r116793: Ensure dired-display-file displays it i


From: Daniel Colascione
Subject: Re: [Emacs-diffs] trunk r116793: Ensure dired-display-file displays it in other window.
Date: Tue, 18 Mar 2014 05:47:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 03/18/2014 05:10 AM, Richard M. Stallman wrote:
> ------------------------------------------------------------
> revno: 116793
> revision-id: address@hidden
> parent: address@hidden
> author: Richard Stallman
> committer: Richard Stallman <address@hidden>
> branch nick: trunk
> timestamp: Tue 2014-03-18 08:07:01 -0400
> message:
>   Ensure dired-display-file displays it in other window.

This change also checks that -a is in dired switches. Please don't do that.

I'm also skeptical of the main hunk:

=== modified file 'lisp/dired.el'
--- a/lisp/dired.el     2014-03-16 09:26:58 +0000
+++ b/lisp/dired.el     2014-03-18 12:07:01 +0000
@@ -2136,7 +2136,8 @@
 (defun dired-display-file ()
   "In Dired, display this file or directory in another window."
   (interactive)
-  (display-buffer (find-file-noselect (dired-get-file-for-visit))))
+  (display-buffer (find-file-noselect (dired-get-file-for-visit))
+                 t))

What bug does that actually fix?

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]