[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patches with independent changes
From: |
Paul Eggert |
Subject: |
Re: Patches with independent changes |
Date: |
Fri, 24 Jan 2014 14:34:35 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/24/2014 01:39 PM, Eli Zaretskii wrote:
they both address the fact that fchmod is not available on Windows.
One without the other would break the build on Windows.
I wasn't referring to two hunks in the patch. I was referring to two of
the changes installed by that patch. One change worked around
WINDOWSNT's lack of fchmod, and the other replaced "!=" with "<".The
changes were independent and only the first change was needed to fix the
bug.
That I used < rather than != is immaterial
You thought replacing "!=" with "<" was needed, so the intent of that
patch was to install multiple independent fixes. Which was fine.
Here's another example. Trunk bzr 116064 fixes a file name handling
failure on MS-Windows 9X. While it's in the neighborhood, it makes the
independent changes of removing initialization code for the variable
g_b_init_is_w9x, and of removing that variable's definition. These
independent changes weren't needed to fix the bug.
This sort of thing is quite common, and there's nothing wrong with it.
[retitling from "Changes in update-game-score.c"]
[Why?]
Others requested retitling and this seemed reasonable.
- Re: Changes in update-game-score.c, (continued)
- Re: Changes in update-game-score.c, Juanma Barranquero, 2014/01/23
- Re: Changes in update-game-score.c, Eli Zaretskii, 2014/01/24
- Re: Changes in update-game-score.c, Paul Eggert, 2014/01/24
- Re: Changes in update-game-score.c, Eli Zaretskii, 2014/01/24
- Re: Changes in update-game-score.c, Jarek Czekalski, 2014/01/24
- Re: Changes in update-game-score.c, Eli Zaretskii, 2014/01/24
- change the Subject line when you change topics [was: Changes in update-game-score.c], Drew Adams, 2014/01/24
- Re: change the Subject line when you change topics [was: Changes in update-game-score.c], Jarek Czekalski, 2014/01/25
- Patches with independent changes, Paul Eggert, 2014/01/24
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/24
- Re: Patches with independent changes,
Paul Eggert <=
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/25
- Re: Patches with independent changes, Paul Eggert, 2014/01/25
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/25
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/25
- Re: Patches with independent changes, Paul Eggert, 2014/01/25
- Re: Patches with independent changes, Eli Zaretskii, 2014/01/25
- Re: Patches with independent changes, Paul Eggert, 2014/01/26