Re: fancy splash screen not shown most of the time

[Claudio Bley]

[ping]

At Tue, 22 Oct 2013 09:02:03 +0200,
Claudio Bley wrote:
> 
> Hi.
> 
> Since a few months (I can't tell exactly when this started happening)
> I noticed that sometimes the splash image would not be displayed when
> starting Emacs; sometimes it worked.

Has anyone else seen this or is it just me?

> How about this patch?
> 
> ------ 8< ------ >8 -------------- 8< --------- >8 ------------------------
> From 9b490d15f3e8f41293f58373004fd251c467b5a2 Mon Sep 17 00:00:00 2001
> From: Claudio Bley <address@hidden>
> Date: Tue, 22 Oct 2013 08:57:26 +0200
> Subject: [PATCH] Ensure to choose a reasonable fancy splash frame on startup
> 
> * startup.el (fancy-splash-frame): Return the currently selected frame
> when no visible frame without active minibuffer was found.
> ---
>  lisp/ChangeLog  | 5 +++++
>  lisp/startup.el | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index fcefcf8..648f23b 100644
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-10-22  Claudio Bley  <address@hidden>
> +
> +     * startup.el (fancy-splash-frame): Return the currently selected frame
> +     when no visible frame without active minibuffer was found.
> +
>  2013-10-16  Michael Albinus  <address@hidden>
>  
>       * net/tramp-smb.el (tramp-smb-acl-program): New customer option.
> diff --git a/lisp/startup.el b/lisp/startup.el
> index 059d771..7cc5d82 100644
> --- a/lisp/startup.el
> +++ b/lisp/startup.el
> @@ -1726,7 +1726,7 @@ we put it on this frame."
>        (if (and (frame-visible-p frame)
>              (not (window-minibuffer-p (frame-selected-window frame))))
>         (setq chosen-frame frame)))
> -    chosen-frame))
> +    (or chosen-frame (selected-frame))))
>  
>  (defun use-fancy-splash-screens-p ()
>    "Return t if fancy splash screens should be used."
> -- 
> 1.8.4.msysgit.0