emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] w32: add support for recent PNG library version >= 1.5


From: Eli Zaretskii
Subject: Re: [PATCH 2/5] w32: add support for recent PNG library version >= 1.5
Date: Tue, 29 Oct 2013 18:50:52 +0200

> Date: Tue, 29 Oct 2013 09:44:01 +0100
> From: Claudio Bley <address@hidden>
> Cc: address@hidden
> 
> At Sun, 27 Oct 2013 18:28:26 +0200,
> Eli Zaretskii wrote:
> > 
> > Here, too, latest libpng versions are incompatible with 1.4.x, so we
> > do need to make such a change.
> > 
> > However, when one builds libpng-X.Y.Z on Windows, the DLL that is
> > installed is called libpngXY-XY.dll, not just libpngXY.dll, as your
> > patch assumes.
> 
> I'm building with CMake and that's what the CMake builds produce.

Worth writing to the maintainers about, IMO, since CMake is not the
standard build method (AFAIK).

> If you download the release tarball (lpng166.7z) for win32, the DLL
> produced is also called libpng16.dll.

If you build with CMake or if you build with the usual "configure && make"?

> > I don't mind supporting both forms, but we must support the form
> > used by "make install" in the libpng distribution.
> > 
> > So could you please modify this patch accordingly?
> 
> OK, I'll add libpngXY-XY.dll as a second alternative, since
> libpngXY.dll seems to be the platform default.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]