[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Broken bootstrap in r113623
From: |
Xue Fuqiao |
Subject: |
Re: Broken bootstrap in r113623 |
Date: |
Thu, 1 Aug 2013 07:15:17 +0800 |
On Thu, Aug 1, 2013 at 12:28 AM, Eli Zaretskii <address@hidden> wrote:
> Xue, please in the future always run "make info" whenever you make any
> changes in the manual. Otherwise, the risk of gratuitously breaking
> the build is quite high.
>
> Please also make a point of mentioning _all_ of your changes in
> ChangeLog entries (in this case, the removal of the "Disabling
> Multibyte" node was never mentioned).
>
> Finally, please use meaningful commit messages. Something like "Doc
> fix" does not have any meaningful information, and thus is useless.
> We use "Doc fix" when making changes to doc strings of Lisp functions,
> but then we always state the name of the function whose doc string was
> fixed, and in any case calling 5 non-trivial changes "Doc fix" is not
> a good idea. Think about the plight of someone who wants to get a
> quick overview of a series of changes by doing "bzr log -l10 --line".
I see, thanks.
--
Best regards, Xue Fuqiao.