emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support f


From: Dmitry Gutov
Subject: Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion'.
Date: Mon, 06 May 2013 06:43:48 +0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5

On 06.05.2013 5:18, Stefan Monnier wrote:
Like the header in company.el says, we still try to support Emacs 22 and
23. `pcase' was only added in 23.3, I believe.
But this is in a comment, so it's not a problem.
I'm not sure recommending to users to write new backends in a way
incompatible with older Emacs is good.

It is in my interest to encourage all users to move to a more
recent Emacs.

I still don't like the dissonance between the "Compatibility" header and this recommendation, not far below it. But if you insist, let's keep it that way.

There are other reasons to install the latest Emacs, like packages using Emacs-24-only features. It doesn't seem to me that Company can really benefit from many of those, so far.

And even more so to encourage them to move away from `cl'
(which will be a long and arduous path, so every bit helps).

While we're on the subject of `cl', why not use `cl-lib' and `cl-case'? I seriously doubt any backend will be able to use the additional features provided by `pcase'.

There are many ways to do initialization in the backend (once per
session, once per buffer, once per blue moon, you name it) without using
`init'.

I guess that is true. And if you're just arguing against having a similar field in `completion-extra-properties', I'm fine with that.

This is totally fine for `company-capf', but `company-begin-with' is an old
function/feature.

But I'm only suggesting to change it in more recent versions of Company,
so it won't affect old users.

That doesn't make sense. Keeping compatibility with Emacs < 24 by definition means not breaking it in the latest version.

package.el doesn't have an easy way to install a non-latest version of a package, so it will affect any users with old Emacs who are updating or reinstalling the package. Provided they sometimes use `company-begin-with', of course.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]