[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: minibuffer-completion-contents obsolete
From: |
Stefan Monnier |
Subject: |
Re: minibuffer-completion-contents obsolete |
Date: |
Sun, 21 Apr 2013 00:03:56 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
>> I use it in helm and eldoc-eval.
> That says where you use it, but not what you use it for.
E.g. why not use the patch below?
Stefan
=== modified file 'packages/eldoc-eval/eldoc-eval.el'
--- packages/eldoc-eval/eldoc-eval.el 2013-01-13 20:20:14 +0000
+++ packages/eldoc-eval/eldoc-eval.el 2013-04-21 04:02:47 +0000
@@ -149,21 +149,15 @@
(defun eldoc-mode-in-minibuffer ()
"Show eldoc for current minibuffer input."
- (let ((buf (with-selected-window (minibuffer-window)
- (buffer-name))))
+ (let ((buf (window-buffer (minibuffer-window))))
;; If this minibuffer have been started with
;;`with-eldoc-in-minibuffer' give it eldoc support
;; and update mode-line, otherwise do nothing.
(when (member buf eldoc-active-minibuffers-list)
- (let* ((str-all (with-current-buffer buf
- (minibuffer-completion-contents)))
- (sym (when str-all
- (with-temp-buffer
- (insert str-all)
- (goto-char (point-max))
+ (let* ((sym (with-current-buffer buf
(unless (looking-back ")\\|\"")
(forward-char -1))
- (eldoc-current-symbol))))
+ (eldoc-current-symbol)))
(info-fn (eldoc-fnsym-in-current-sexp))
(doc (or (eldoc-get-var-docstring sym)
(eldoc-get-fnsym-args-string