Re: Note on 109327

[Eli Zaretskii]

> From: Juanma Barranquero <address@hidden>
> Date: Tue, 31 Jul 2012 15:54:38 +0200
> Cc: Emacs development discussions <address@hidden>
> 
> On Tue, Jul 31, 2012 at 2:38 PM, Dmitry Antipov <address@hidden> wrote:
> 
> > Please report possible Windows/NS build errors as soon as possible.
> 
> fontset.c: In function 'dump_fontset':
> fontset.c:2119:6: error: 'struct frame' has no member named 'name'

Which has nothing to do with Windows, but with --enable-checking.

This problem, however, is more serious, IMO:

  gcc -I. -c -gdwarf-2 -g3  -DEMACSDEBUG -fno-crossjumping  
-Id:/usr/include/libxml2 -DGLYPH_DEBUG=1 -Demacs=1 -I../lib -I../nt/inc 
-DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -o oo/i386/w32menu.o w32menu.c
  w32menu.c: In function `w32_menu_show':
  w32menu.c:857: error: structure has no member named `title_'
  makefile:322: recipe for target `oo/i386/w32menu.o' failed
  make[1]: *** [oo/i386/w32menu.o] Error 1

AFAIU, it means that coccinelle made an incorrect replacement.

I fixed both of these in revision 109332.

Btw, can't we have in Emacs a feature that would allow such
refactoring?  The replacements don't seem too complex to me.  Adding
this to Emacs will both allow getting rid of an external tool, and be
a valuable addition to Emacs abilities.  WDYT?