emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation


From: Jérémy Compostella
Subject: Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation
Date: Sat, 21 Jan 2012 11:05:26 +0100

As we agreed about the solution, could you please merge this patch ?
This bug is really annoying to me and probably to many others.

Thanks.

Jérémy

2012/1/20 Jérémy Compostella <address@hidden>
2012/1/20 martin rudalics <address@hidden>
> Effectively the issue is only windmove.el related.

So IIUC the issue is that `windmove-reference-loc'

         (windmove-coord-add
            top-left
            (let ((col-row
                   (posn-col-row
                    (posn-at-point (window-point window) window))))
              (cons (- (car col-row) (window-hscroll window))
                    (cdr col-row)))))))))

wrongly subtracts the value returned by `window-hscroll' from a column
value correctly calculated by `posn-at-point' (window_box_left_offset)?

Yes, you're perfectly right that's my point and my patch remove this.
Thanks.

It's time to friday beer evening now :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]