[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] Refactor window-system configuration
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 2/4] Refactor window-system configuration |
Date: |
Fri, 30 Dec 2011 10:21:34 +0200 |
> Date: Thu, 29 Dec 2011 14:29:24 -0800
> From: Daniel Colascione <address@hidden>
> Cc: address@hidden
>
> My initial revisions actually did exactly what you suggest, but I
> realized that the solution was more complex and didn't actually have
> any benefit.
Can you describe the complexity in this solution?
> > Also "TERM" does not look like a good prefix
> > in this case, it's meaning might be confused with the TERM environment
> > variable (nsterm/w32term/xterm are not that great either, but better not
> > propagate the confusion).
>
> "Term", I think, it pretty clear in the context of Emacs. Using a
> different name for the header constant wouldn't change the names of all
> the datatypes in that header. It's better to at least be consistently
> confusing.
>
> There's XTERM_HEADER, but this name has other issues.
How about WINSYS_HEADER?
- [PATCH 2/4] Refactor window-system configuration, (continued)
- [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Dan Nicolaescu, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Dan Nicolaescu, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Dan Nicolaescu, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration,
Eli Zaretskii <=
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Stefan Monnier, 2011/12/31
- Re: [PATCH 2/4] Refactor window-system configuration, Stefan Monnier, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
[PATCH 3/4] Implement cygw32, Daniel Colascione, 2011/12/29