emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: secure plist store


From: Ted Zlatanov
Subject: Re: secure plist store
Date: Wed, 29 Jun 2011 09:34:49 -0500
User-agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)

On Wed, 29 Jun 2011 20:59:10 +0900 Daiki Ueno <address@hidden> wrote: 

DU> Ted Zlatanov <address@hidden> writes:
>> I would appreciate it if you were more specific about "does not work" by
>> either filing a bug or explaining.  Obviously it works for me and Lars,
>> who tested it.  Similarly, since you wrote EPA/EPG, your advice on
>> reducing complexity when we use it is greatly appreciated but you don't
>> give us any here.

DU> I have too many minor comments to list here, but at least duplicate code
DU> regarding stashfile should be simplified by supplying a custom
DU> passphrase-callback and calling epg-{encrypt,decrypt}-string.  Currently
DU> it's really hard to understand what the code does.

I am attaching an auth-source.el patch based on the plstore.el code.  It
simplifies things greatly.

I have one suggestion, that `epa-passphrase-callback-function' should
take an extra detail string, as shown in my patch:

(defun auth-source-passphrase-callback-function (context key-id handback
                                                         &optional sym-detail)
"Exactly like `epa-passphrase-callback-function' but takes an
extra SYM-DETAIL parameter which will be printed at the end of
the symmetric passphrase prompt."
...

That makes it possible to prompt for "passphrase for file xyz tokens:"
instead of just "passphrase for file xyz:" (I think the latter is
confusing to the user).

Obviously that's not strictly needed since I can write my own function
as you see.

If you could review the new code, I would appreciate any comments you
may have.

Ted




reply via email to

[Prev in Thread] Current Thread [Next in Thread]