Fwd: flymake-start-syntax-check-process ignores dir setting

[David Reitter]

Here's a patch from someone regarding flymake.el.
I think that if this is good, it should be applied upstream.

Begin forwarded message:

> From: Duncan Findlay <address@hidden>
> Date: April 5, 2011 9:13:36 PM EDT
> To: address@hidden
> Subject: [Aquamacs-bugs] 23.3; flymake-start-syntax-check-process ignores dir 
> setting
> Reply-To: Bug reports for Aquamacs Emacs <address@hidden>
> 
> Hi,
> 
> I'm having trouble using flymake in Aquamacs 2.2. I want to run "pyflakes" on 
> my local host while editing remote Python (.py) files. This worked in 
> Aquamacs 2.1, but it looks like 2.2 now has support for running commands on 
> remote hosts. This is a good thing, but unfortunately, I don't want pyflakes 
> running remotely.
> 
> (The relavent change is here: 
> https://github.com/davidswelt/aquamacs-emacs/commit/7a542acd40a722a556dcadc039aa8e00645dfd00#lisp/progmodes/flymake.el)
> 
> From looking through the source, it looks like 
> flymake-start-syntax-check-process takes a dir argument, so that one can 
> customize what directory the flymake syntax checking process starts in. Now 
> that this function calls start-file-process instead of start-process, this 
> dir argument also ought to control what host the process starts on, so I can 
> use it to make sure it starts locally.
> 
> Unfortunately this dir variable seems to be pretty much ignored. I'm not 
> competent in Emacs Lisp, but I did come up with this ugly patch (attached) 
> that seems to work. I'm sure there's a much simpler and more elegant way to 
> do what I'm trying to do, but hopefully you get the idea.
> 
> The relevant section of my Preferences.el used to set up flymake to run 
> pyflakes on Python files is also attached. 
> 
> Thanks
> 
> Duncan
> 
> 
> 
>

patch
Description: Binary data

Preferences.el
Description: Binary data

>