emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X


From: Chong Yidong
Subject: Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X
Date: Mon, 21 Feb 2011 12:40:06 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Ben Key <address@hidden> writes:

> For one, the change to src/xdisp.c is critical.  Otherwise there would
> be places in get_specified_cursor_type where width is not initialized
> before the function exits and the FIXME comments in
> ns_draw_window_cursor would still be valid.  For example, just two
> lines below where I added the line "*width = 2;" is a return
> statement.  If the line initializing width were not added and the arg
> parameter was equal to nil, the function get_specified_cursor_type
> would exit without width being initialized.

nsterm.m's usage of get_specified_cursor_type should follow the same
logic as the other terminals.  If the NS terminal alone requires a
change to get_specified_cursor_type, that is a bug in nsterm.m; changing
get_specified_cursor_type only papers over this bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]