[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug: epg send unencrypted data in trash
From: |
Thierry Volpiatto |
Subject: |
Re: bug: epg send unencrypted data in trash |
Date: |
Sat, 12 Feb 2011 08:08:22 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.2.93 (gnu/linux) |
Chong Yidong <address@hidden> writes:
> Ted Zlatanov <address@hidden> writes:
>
>> On Fri, 11 Feb 2011 22:05:09 +0100 Thierry Volpiatto
>> <address@hidden> wrote:
>>
>> TV> Ted Zlatanov <address@hidden> writes:
>>>> According to the docs for `delete-file' it shouldn't matter what
>>>> `delete-by-moving-to-trash' says because this is called
>>>> non-interactively (TRASH is nil when delete-file is called
>>>> non-interactively). Or is this funcall interactive somehow?
>> TV> I don't know, but actually without delete-by-moving-to-trash let-bound
>> TV> to nil, non--encrypted data goes to trash.
>>
>> I think this is because in the C source (fileio.c) TRASH is set to
>> "(null current-prefix-arg)" which is not equivalent to
>> `called-interactively-p' AFAIK. IOW I think your fix is masking the
>> underlying problem. But I don't know the C source so well so I could be
>> misunderstanding things. Perhaps Chong Yidong, who created revision
>> 100462 and introduced the TRASH parameter, can check it.
>
> I think TV is using the emacs-23 branch,
Yes.
> where the TRASH parameter is
> not present. I've changed EPA and EPG to bind delete-by-moving-to-trash
> to nil there. No fix is necessary for the trunk, IIUC.
>
>
--
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
- bug: epg send unencrypted data in trash, Thierry Volpiatto, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Thierry Volpiatto, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Thierry Volpiatto, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/11
- Re: bug: epg send unencrypted data in trash, Chong Yidong, 2011/02/11
- Re: bug: epg send unencrypted data in trash,
Thierry Volpiatto <=
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/12
- Re: bug: epg send unencrypted data in trash, Chong Yidong, 2011/02/12
- Re: bug: epg send unencrypted data in trash, Ted Zlatanov, 2011/02/12