|
From: | Jan Djärv |
Subject: | Re: bug#7859: syncing Emacs from sources maintained elsewhere |
Date: | Thu, 20 Jan 2011 07:45:17 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 |
Paul Eggert skrev 2011-01-20 00.44:
I see that Jan Djärv tracked the problem down: unexmacosx.c included<unistd.h> before<config.h>, and this caused the problem. Generally speaking,<config.h> should be included before all other files, since it defines macros such as _FILE_OFFSET_BITS that may affect the ABI, and compiling files sometimes with one ABI and sometimes with another can lead to disaster. I see that unexmacos.c still doesn't include<config.h> first, though. I suggest that it be changed to do that.
Not possible, I added this comment: /* config.h #define:s malloc/realloc/free and then includes stdlib.h. We want the undefined versions, but if config.h includes stdlib.h with the #define:s in place, the prototypes will be wrong and we get warnings. To prevent that, include stdlib.h before config.h. */ Jan D.
[Prev in Thread] | Current Thread | [Next in Thread] |