[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs-diffs Digest, Vol 94, Issue 89
From: |
Chong Yidong |
Subject: |
Re: Emacs-diffs Digest, Vol 94, Issue 89 |
Date: |
Fri, 24 Sep 2010 18:08:35 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>> - int frame_lines = FRAME_LINES (frame);
>> + EMACS_INT frame_lines = FRAME_LINES (frame);
>
> I think down that lane lies madness, because we have lots of struct
> members that are Lisp integers, and assigning the result of XINT of
> every one of them to an EMACS_INT will significantly and unnecessarily
> increase our stack usage (on 64-bit machines).
I think text_lines and related members of `struct frame' should be ints.
Dunno why they were made EMACS_INT, though it happened long ago, before
Emacs-21.
I doubt there is much practical difference, only a conceptual one; IMO
the "EMACS_INT" cast is a nice way to denote that an integer may have to
do with buffer and string sizes.
I don't feel strongly about it, though.
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Lars Magne Ingebrigtsen, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, David Kastrup, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, David Kastrup, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89,
Chong Yidong <=
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/25
Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Lars Magne Ingebrigtsen, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/26
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Chong Yidong, 2010/09/27