[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick br
From: |
joakim |
Subject: |
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk |
Date: |
Thu, 19 Aug 2010 14:28:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Juanma Barranquero <address@hidden> writes:
> A few nitpicks (not related to code, just the merge).
>
> On Thu, Aug 19, 2010 at 09:35, Joakim <address@hidden> wrote:
>
>> modified:
>> ChangeLog
>
> There's just a ChangeLog entry, at top level, but the changes should
> be documented in the respective ChangeLogs (src/ChangeLog for src/*
> changes, etc.).
>
>> configure
>> doc/lispref/display.texi
>> etc/NEWS
>> lisp/image-mode.el
>
> These aren't mentioned in any ChangeLog.
>
>> +2010-06-12 Joakim Verona <address@hidden>
>
> When merging branches, the date of the ChangeLog is the date the merge
> is done, not that of the original changes (that information is
> preserved by the branch history).
>
>> + * image.c: Add support for ImageMagick. When HAVE_IMAGEMAGICK is
>> + defined:
>
> Usually that information is conveyed by "[HAVE_IMAGEMAGICK]".
>
>> + * config.in, Makefile.in, configure.in
>
> These files do not have a change description in the entry.
Ok, Ill try to fix these issues.
> Juanma
>
--