[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer).
From: |
Karl Fogel |
Subject: |
Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer). |
Date: |
Wed, 14 Jul 2010 12:06:02 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Thierry Volpiatto <address@hidden> writes:
>> patch. You used (or kept) parameter names `point-only' and
>> `read-only';
>
>kept: point-only
>added: read-only
Thanks (I was just writing tersely in my email).
>> I changed those to `no-file' and `no-context', to describe what they are
>
>Yes nice these names are better.
Glad you agree!
>I will try to retrieve the patch for Emacs, if i don't retrieve it, it
>would be good you commit the changes without the C-w feature and i will
>create a patch that apply on top of this.(I really don't remember yet
>what i changed to make that working, need to check my logs and
>bookmark-extensions.el)
I have committed the changes, including the changes to Gnus (see Bzr
revs below). Please post the C-w patch and I will apply that too.
Thanks!
-Karl
------------------------------------------------------------
revno: 100820
revision-id: address@hidden
parent: address@hidden
committer: Karl Fogel <address@hidden>
branch nick: trunk
timestamp: Wed 2010-07-14 12:02:53 -0400
message:
Allow bookmarks to be set from Gnus Article buffers (Bug #5975).
Patch applied (with minor tweaks) by Karl Fogel. Note this leaves
C-w still not working correctly from Article buffers; Thierry's
patch to fix that will be applied after this.
* lisp/gnus/gnus-art.el (bookmark-make-record-function): New local variable.
* lisp/gnus/gnus-sum.el (gnus-summary-bookmark-make-record): Allow setting
from article buffer.
(gnus-summary-bookmark-jump): Maybe jump to article buffer.
------------------------------------------------------------
revno: 100819
revision-id: address@hidden
parent: address@hidden
committer: Karl Fogel <address@hidden>
branch nick: trunk
timestamp: Wed 2010-07-14 11:57:54 -0400
message:
Preparation for setting bookmarks in Gnus article buffers (Bug#5975).
* lisp/bookmark.el (bookmark-make-record-default): Allow unneeded
information to be omitted from the record.
Adjust declarations and calls:
* lisp/info.el (bookmark-make-record-default): Adjust declaration.
(Info-bookmark-make-record): Adjust call.
* lisp/woman.el (bookmark-make-record-default): Adjust declaration.
(woman-bookmark-make-record): Adjust call.
* lisp/man.el (bookmark-make-record-default): Adjust declaration.
(Man-bookmark-make-record): Adjust call.
* lisp/image-mode.el (bookmark-make-record-default): Adjust declaration.
* lisp/doc-view.el (bookmark-make-record-default): Adjust declaration.
* lisp/gnus/gnus-sum.el (bookmark-make-record-default): Adjust declaration.
------------------------------------------------------------
Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer)., Glenn Morris, 2010/07/13
Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer)., Thierry Volpiatto, 2010/07/14
- Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer).,
Karl Fogel <=