emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Header lines of commit messages


From: Eli Zaretskii
Subject: Header lines of commit messages
Date: Sat, 26 Jun 2010 13:43:37 +0300

Commit messages such as the one below are not helpful:

    revno: 100645
    author: Carsten Dominik <address@hidden>
    committer: Romain Francoise <address@hidden>
    branch nick: trunk
    timestamp: Sat 2010-06-26 11:53:06 +0200
    message:
      Cherry-pick commit 8bd9308 from the org-mode Git repository.

      2010-06-26  Carsten Dominik  <address@hidden>

            * org-agenda.el (org-agenda-goto-calendar): Do not bind obsolete
            variables.

            * org.el (calendar): Require calendar now on top level in org.el
            and define aliases to new variables when needed.
            (org-read-date, org-goto-calendar): Do not bind obsolete
            variables.

The header line that summarizes the commit conveys useless
information.  It should state the essence of the change instead, so
that people who use "bzr log --line" will be able to grasp the purpose
of the change without looking at the full text.  The info about the
commit number, if it's deemed to be important, should be in the body
of the commit message, not in the header line.

TIA



reply via email to

[Prev in Thread] Current Thread [Next in Thread]