[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#5703: 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do no
From: |
Eli Zaretskii |
Subject: |
Re: bug#5703: 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top' |
Date: |
Wed, 31 Mar 2010 12:17:19 +0300 |
> Date: Wed, 31 Mar 2010 08:33:25 +0900
> From: YAMAMOTO Mitsuharu <address@hidden>
> Cc: Chong Yidong <address@hidden>, address@hidden,
> address@hidden, address@hidden
>
> > I see almost identical code in xfns.c versions of these functions,
> > so I'd be interested to hear how come the X version does not suffer
> > from the same problem. That's because the patch below, although it
> > does the job, feels a bit kludgey, and I wonder if there a cleaner
> > way.
>
> Because x_create_tip_frame in xfns.c makes a copy of `parms'?
Right, I missed that. Thanks.
So I committed to the emacs-23 branch the following patch which fixes
the bug:
=== modified file 'src/ChangeLog'
--- src/ChangeLog 2010-03-31 04:00:23 +0000
+++ src/ChangeLog 2010-03-31 09:08:40 +0000
@@ -1,3 +1,8 @@
+2010-03-31 Eli Zaretskii <address@hidden>
+
+ * w32fns.c (x_create_tip_frame): Copy `parms' before we modify it
+ in this function. (Bug#5703)
+
2010-03-31 Chong Yidong <address@hidden>
* nsterm.h: Fix last change.
=== modified file 'src/w32fns.c'
--- src/w32fns.c 2010-01-13 08:35:10 +0000
+++ src/w32fns.c 2010-03-31 09:08:40 +0000
@@ -5427,6 +5427,10 @@ x_create_tip_frame (dpyinfo, parms, text
kb = dpyinfo->terminal->kboard;
+ /* The calls to x_get_arg remove elements from PARMS, so copy it to
+ avoid destructive changes behind our caller's back. */
+ parms = Fcopy_alist (parms);
+
/* Get the name of the frame to use for resource lookup. */
name = x_get_arg (dpyinfo, parms, Qname, "name", "Name", RES_TYPE_STRING);
if (!STRINGP (name)