[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: colours in client on xterm (if an X frame is open at same time)
From: |
Dan Nicolaescu |
Subject: |
Re: colours in client on xterm (if an X frame is open at same time) |
Date: |
Sun, 10 Jan 2010 00:49:53 -0800 (PST) |
Eli Zaretskii <address@hidden> writes:
> > Date: Fri, 8 Jan 2010 20:18:58 -0800 (PST)
> > From: Dan Nicolaescu <address@hidden>
> > Cc: address@hidden
> >
> > > In your case the only effect that patch should have is to move the
call
> > > (tty-set-up-initial-frame-faces) from before
> > >
> > > (let ((coding-system-for-read 'binary)
> > >
> > > to after it.
> >
> > If I put back the `tty-set-up-initial-frame-faces' call (after
> > `xterm-register-default-colors') and make current
> > `tty-set-up-initial-frame-faces' conditional on detecting a dark
> > background, then everything seems to work OK.
> >
> > Calling `tty-set-up-initial-frame-faces' twice in the dark background
> > case is very ugly, but in case nobody finds a better solution soon I'll
> > check in that change soon.
>
> I wasn't following this thread. I don't know if I can help, but
> there's something I don't understand: is it the case that the new code
> mis-computes the background reported by xterm? That is, it sets up
> for a dark background when it is in fact light?
No, the background mode is computed just fine, and it's light (the
default for xterm anyway).
> Or is the background mode computed correctly, but the call to
> tty-set-up-initial-frame-faces in its new location does not do what
> it's expected to do?
>
> If the latter, then I'd step through tty-set-up-initial-frame-faces to
> see what goes wrong there. I see that it calls
> frame-set-background-mode, so perhaps the problem is within that
> function.
In the case where everything works correctly (before the patch),
when stepping through frame-set-background-mode (called by
tty-set-up-initial-frame-faces) the default face gets set up wrong.
So debugging hurts in this case :-(
- colours in client on xterm (if an X frame is open at same time), Ulrich Mueller, 2010/01/07
- Re: colours in client on xterm (if an X frame is open at same time), Dan Nicolaescu, 2010/01/07
- Re: colours in client on xterm (if an X frame is open at same time), Ulrich Mueller, 2010/01/08
- Re: colours in client on xterm (if an X frame is open at same time), Dan Nicolaescu, 2010/01/08
- Re: colours in client on xterm (if an X frame is open at same time), Ulrich Mueller, 2010/01/08
- Re: colours in client on xterm (if an X frame is open at same time), Dan Nicolaescu, 2010/01/08
- Re: colours in client on xterm (if an X frame is open at same time), Ulrich Mueller, 2010/01/08
- Re: colours in client on xterm (if an X frame is open at same time), Dan Nicolaescu, 2010/01/08
- Re: colours in client on xterm (if an X frame is open at same time), Eli Zaretskii, 2010/01/09
- Re: colours in client on xterm (if an X frame is open at same time),
Dan Nicolaescu <=
- Re: colours in client on xterm (if an X frame is open at same time), Eli Zaretskii, 2010/01/10
- Re: colours in client on xterm (if an X frame is open at same time), Dan Nicolaescu, 2010/01/10
- Re: colours in client on xterm (if an X frame is open at same time), Jan Djärv, 2010/01/08
- Re: colours in client on xterm (if an X frame is open at same time), Dan Nicolaescu, 2010/01/08
Re: colours in client on xterm (if an X frame is open at same time), Eric Hanchrow, 2010/01/07