emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] espresso-mode breaks on JSON input


From: Daniel Colascione
Subject: Re: [PATCH] espresso-mode breaks on JSON input
Date: Fri, 11 Sep 2009 19:25:51 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Good catch! Thanks.

On Sep 11, 2009, at 7:19 PM, Deniz Dogan wrote:
Attached is the patch. I'm not sure about the format, but I hope it can be used.

Just FYI, patch(1) can cope with emails that include a patch at the end. It's usually better to include a patch inline than to attach it. Doing it that way makes patches easier to discuss.

This patch does the same thing yours does, but more concisely.

Index: js.el
===================================================================
- --- js.el     (revision 213)
+++ js.el       (working copy)
@@ -1808,7 +1808,7 @@
              (if (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)")
                  (progn
                    (skip-syntax-backward " ")
- -                   (when (= (char-before) ?\)) (backward-list))
+                   (when (eq (char-before) ?\)) (backward-list))
                    (back-to-indentation)
                    (cond (same-indent-p
                           (current-column))

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iEYEARECAAYFAkqq3H8ACgkQ17c2LVA10VualQCg43C6Egs9ie9P7CE5uVbdxG1q
2WIAoIWS3JqwJ4hes24+3jcq8r0C13M1
=+s+8
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]