emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Changes in callproc.c and term.c


From: Eli Zaretskii
Subject: Changes in callproc.c and term.c
Date: Fri, 03 Jul 2009 17:40:53 +0300

Dan, I have a comment about this change committed today:

    2009-07-03  Dan Nicolaescu  <address@hidden>

            * callproc.c (child_setup): Use #else instead of a separate #ifdef.

This change is perfectly okay syntactically and semantically, of
course.  What bothers me is that it made two unrelated code snippets
look as if they do similar or related things on two different
platforms, because now they are in two sibling branches of the same
#ifdef.

However, this is a matter of style and personal preferences, so I'll
let Stefan and Yidong decide.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]