emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: menu-bar.el: x-selection-exists-p


From: Stefan Monnier
Subject: Re: menu-bar.el: x-selection-exists-p
Date: Tue, 03 Mar 2009 09:15:07 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux)

> Are the below  changes OK, and is it OK to check this in at this point?

The second change is OK (I'd fold the "if" into that "and", but that's
just me).  The first doesn't seem quite right: I think it should test
something like:
  
  (or (and (fboundp 'x-selection-exists-p) (x-selection-exists-p))
      kill-ring)

to better reflect the fact that `yank' either uses the selection or the
kill-ring.

Thanks for spotting this.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]