[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog
From: |
Chong Yidong |
Subject: |
Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog |
Date: |
Wed, 10 Dec 2008 11:35:26 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
"Juanma Barranquero" <address@hidden> writes:
> But the base discussion is whether features should be tested by
> feature tests, or lumped together into the WINDOWSNT, DOS_NT,
> NS_IMPL_* bags. We've been saying for years that Emacs lisp programs
> must not check the Emacs version, but features. The same reasoning
> applies to checking HAVE_DAEMON vs. WINDOWSNT.
That's typically true, but again: specifics matter. For instance, if
the majority of the code controlled by the HAVE_DAEMON macro is
platform-dependent anyway, we would simply be replacing
#ifdef WINDOWSNT
...
#endif
with
#ifdef HAVE_DAEMON
#ifdef WINDOWSNT
...
#endif
...
#endif
Which situation pertains in the actual code?
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Juanma Barranquero, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Juanma Barranquero, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Dan Nicolaescu, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Jason Rumney, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Juanma Barranquero, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Dan Nicolaescu, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Lennart Borgman, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Dan Nicolaescu, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Lennart Borgman, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Dan Nicolaescu, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Lennart Borgman, 2008/12/10
- Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog, Dan Nicolaescu, 2008/12/10