Re: Can we apply this patch for bug 84 and 425?

[Stefan Monnier]

> These bugs are both about hangs when emacs deals with external processes:
>    http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=84
>    http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=425

> Markus Triska has a patch which reduces my experiences of the hang from
> about once a day to not at all so far.

> How can we proceed with this patch? 

> diff --git a/src/process.c b/src/process.c
> index e8d0090..0cf04bc 100644
> --- a/src/process.c
> +++ b/src/process.c
> @@ -4791,6 +4791,10 @@ wait_reading_process_output (time_limit, microsecs, 
> read_kbd, do_display,
>             else if (nread == -1 && EWOULDBLOCK == errno)
>                  break;
>  #endif
> +#ifdef EBADF
> +           else if (nread == -1 && EBADF == errno)
> +             break;
> +#endif
>           }
>         if (total_nread > 0 && do_display)
>           redisplay_preserve_echo_area (10);

This patch is not acceptable as-is: EBADF should normally be a symptom
of another bug in Emacs (we should never pass a bad descriptor), so
rather than ignore it, we should figure out where it comes from and fix
it there.


        Stefan