[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Recent CVS Emacs breaks color-themes
From: |
Kenichi Handa |
Subject: |
Re: Recent CVS Emacs breaks color-themes |
Date: |
Sat, 04 Oct 2008 11:45:02 +0900 |
User-agent: |
SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
In article <address@hidden>, martin rudalics <address@hidden> writes:
> (font_matching_entity): Reflect ATTRS in font selection.
> (font_find_for_lface) [HAVE_NS]: Don't ignore case.
> There's something strange with that change. The lines
> ASET (spec, FONT_TYPE_INDEX, ftype);
> ASET (spec, FONT_SIZE_INDEX, size);
> before line 2802
> font_add_log ("match", work, entity);
> disappeared. I don't have the slightest idea whether that's of
> any importance. Moreover, "spec" should probably become "work"
> here. Handa-san?
That disappearance is because of Adrian's change just a few
hours after of my commit. But, that is ok because
font_matching_entity now uses "work" and don't modify
"spec", the above two lines are not necessary.
And, the code I checked in had a problem of not setting font
size of "work", but that is already fixed by Adrian too.
By the way, Adrian, please add ChangeLog entry for them:
(Just saying "Fix previous change" is ok).
So, I don't know what is wrong with the current code, and I
can't reproduce your problem even with this setting of
yours:
--8<---------------cut here---------------start------------->8---
*FontBackend: xft,x
Emacs.FontBackend: xft,x
emacs.font: DejaVu Sans Mono-9
--8<---------------cut here---------------end--------------->8---
---
Kenichi Handa
address@hidden
- Recent CVS Emacs breaks color-themes, Manoj Srivastava, 2008/10/03
- Re: Recent CVS Emacs breaks color-themes, Stefan Monnier, 2008/10/03
- Re: Recent CVS Emacs breaks color-themes, martin rudalics, 2008/10/03
- Re: Recent CVS Emacs breaks color-themes, Manoj Srivastava, 2008/10/03
- Re: Recent CVS Emacs breaks color-themes, martin rudalics, 2008/10/03
- Re: Recent CVS Emacs breaks color-themes,
Kenichi Handa <=
- Re: Recent CVS Emacs breaks color-themes, Manoj Srivastava, 2008/10/04
- Re: Recent CVS Emacs breaks color-themes, Kenichi Handa, 2008/10/05
- Re: Recent CVS Emacs breaks color-themes, Manoj Srivastava, 2008/10/06
- Re: Recent CVS Emacs breaks color-themes, Kenichi Handa, 2008/10/06
- Re: Recent CVS Emacs breaks color-themes, Manoj Srivastava, 2008/10/06
- Re: Recent CVS Emacs breaks color-themes, Manoj Srivastava, 2008/10/06
- Re: Recent CVS Emacs breaks color-themes, Kenichi Handa, 2008/10/08
- Re: Recent CVS Emacs breaks color-themes, Miles Bader, 2008/10/08
- Re: Recent CVS Emacs breaks color-themes, Manoj Srivastava, 2008/10/09
- Re: Recent CVS Emacs breaks color-themes, Kenichi Handa, 2008/10/09