[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fixing non-NS darwin
From: |
Dan Nicolaescu |
Subject: |
Re: fixing non-NS darwin |
Date: |
Sun, 03 Aug 2008 18:11:19 -0700 |
Adrian Robert <address@hidden> writes:
> On Aug 3, 2008, at 11:59 AM, Dan Nicolaescu wrote:
>
> > While at it, can you please get rid of -DMAC_OSX from src/s/darwin.h?
>
> After some discussion with other developers, I think there will need
> to be some kind of #define there, analogous to WINDOWSNT in s/ms-
> w32.h, GNU_LINUX in s/gnu-linux.h, etc.. MAC_OSX is wrong because it
> could be a non-OS X Darwin system. DARWIN is wrong because that is
> apparently defined by the system includes and/or compiler on non-OS X
> Darwin (see below). I don't think just the BSD4_2 that's in darwin.h
> is specific enough.
>
> I am thinking something like DARWIN_BASED_OS?
Is there something that the compiler defines by default? If there is,
it would be better to use that instead.
If not, I'd vote for DARWIN_OS because is shorter.
> > And please add documentation to admin/CPP-DEFINES for the DARWIN
> > macro.
>
> This is not defined anywhere in emacs, but there was this section in
> an earlier version of darwin.h:
>
> #if 0 /* Don't define DARWIN on Mac OS X because CoreFoundation.h uses
> it to distinguish Mac OS X from bare Darwin. */
> #ifndef DARWIN
> #define DARWIN 1
> #endif
> #endif
>
> Does anyone know where this IS defined? Also, I've been unable to
> find a version of CoreFoundation.h that makes the check referred to.
So what should happen to the code that checks for DARWIN ?
- Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change), Adrian Robert, 2008/08/03
- Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change), YAMAMOTO Mitsuharu, 2008/08/03
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/03
- Re: fixing non-NS darwin, YAMAMOTO Mitsuharu, 2008/08/03
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/03
- Re: fixing non-NS darwin, YAMAMOTO Mitsuharu, 2008/08/03
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/04
- Re: fixing non-NS darwin, Thien-Thi Nguyen, 2008/08/04
- Re: fixing non-NS darwin, Dan Nicolaescu, 2008/08/04
Re: fixing non-NS darwin,
Dan Nicolaescu <=
Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change), Adrian Robert, 2008/08/04