Re: line-move-visual never set to nil?

[Chong Yidong]

"Andrew W. Nosenko" <address@hidden> writes:

> The biggest problem with "visual" line motion ...  is that current
> defaults are beaks keybord macro.  Just try to record some macro that
> uses up/down key having wrapped lines, change width of the
> window/frame and enjoy. :-(

That's a good point.  That's also why line-move doesn't try to scroll
tall images when executing a keyboard macro.  Maybe line-move-visual
needs the same treatment, like in the following patch.  WDYT?

*** trunk/lisp/simple.el.~1.939.~       2008-07-28 10:55:05.000000000 -0400
--- trunk/lisp/simple.el        2008-07-29 10:32:51.000000000 -0400
***************
*** 3978,3994 ****
  ;; a cleaner solution to the problem of making C-n do something
  ;; useful given a tall image.
  (defun line-move (arg &optional noerror to-end try-vscroll)
!   (unless (and auto-window-vscroll try-vscroll
!              ;; Only vscroll for single line moves
!              (= (abs arg) 1)
!              ;; But don't vscroll in a keyboard macro.
!              (not defining-kbd-macro)
!              (not executing-kbd-macro)
!              (line-move-partial arg noerror to-end))
!     (set-window-vscroll nil 0 t)
!     (if line-move-visual
!       (line-move-visual arg noerror)
!       (line-move-1 arg noerror to-end))))
  
  ;; Display-based alternative to line-move-1.
  ;; Arg says how many lines to move.  The value is t if we can move the
--- 3978,3996 ----
  ;; a cleaner solution to the problem of making C-n do something
  ;; useful given a tall image.
  (defun line-move (arg &optional noerror to-end try-vscroll)
!   (if (or defining-kbd-macro executing-kbd-macro)
!       ;; If inside a keyboard macro, don't vscroll and don't move by
!       ;; screen lines.
!       (progn (set-window-vscroll nil 0 t)
!            (line-move-1 arg noerror to-end))
!     ;; Otherwise, only vscroll for single line moves
!     (unless (and auto-window-vscroll try-vscroll
!                (= (abs arg) 1)
!                (line-move-partial arg noerror to-end))
!       (set-window-vscroll nil 0 t)
!       (if line-move-visual
!         (line-move-visual arg noerror)
!       (line-move-1 arg noerror to-end)))))
  
  ;; Display-based alternative to line-move-1.
  ;; Arg says how many lines to move.  The value is t if we can move the