emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Finding the source of Change Log entries


From: Juri Linkov
Subject: Re: Finding the source of Change Log entries
Date: Mon, 14 Jul 2008 01:14:11 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu)

>> Please check it in, with the appropriate ChangeLog and NEWS
>> entries, plus the following fix:
>>
>> +       (message "Not found `%s' in %s" tag file)
>>
>> should be something more grammatical, like
>>
>> +       (message "Source location not found: `%s' in %s" tag file)
>>
>> Also, instead of binding change-log-find-tag to C-c C-t, how about using
>> C-c C-c for consistency with diff-mode?  (You might also want to rename
>> change-log-find-tag to change-log-goto-source for consistency with
>> diff-goto-source, but that's your call.)
>
> Done.  Please check again.

Thanks, this is great.  One thing that doesn't work yet is visiting
a file that has no tag, i.e.

        * filename.el: File-level changes.

Instead of visiting it, `C-c C-c' visits the previous file that has
a tag.  Of course, `C-c C-f' is available to visit a file, but it is
not convenient to switch between different keys to do the same thing,
and also `C-c C-f' has a different behavior: it visits a file in the
same window unlike `C-c C-c'.

It seems the best thing to do would be searching backward for a tag and
a file name at the same.  This may require joining two separate functions
that search a tag or a file name into one function.

-- 
Juri Linkov
http://www.jurta.org/emacs/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]