emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Yanking isearch to highlight-regexp


From: Stefan Monnier
Subject: Re: Yanking isearch to highlight-regexp
Date: Sat, 28 Jun 2008 18:23:59 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> Below is a patch that unifies two similar regexp-reading functions
> `keep-lines-read-args' and `occur-read-primary-args' into the general
> function `read-regexp'.  It reads a regexp using the regexp history
> and provides some useful defaults.  Like `keep-lines-read-args'
> it accepts the prompt as its argument, but without the trailing colon
> to be able to add the default value in parentheses.

Sounds good.

> But now the prompt for `keep-lines' doesn't look nice since
> it displays parentheses twice as:

>   Keep lines (containing match for regexp) (default regexp): 

> maybe a better format would be:

>   Keep lines, containing match for regexp (default regexp): 

Yes, that's better, tho I'd even drop the comma.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]