Re: font-related hanging / general brokenness

[Kenichi Handa]

In article <address@hidden>, Miles Bader <address@hidden> writes:

> [1  <text/plain (7bit)>]
> Updating to the newest CVS Emacs, Emacs goes into an infinite-loop upon
> startup, with the following .emacs file (X resources are empty):

>    (custom-set-faces
>      ;; custom-set-faces was added by Custom.
>      ;; If you edit it by hand, you could mess it up, so be careful.
>      ;; Your init file should contain only one such instance.
>      ;; If there is more than one, they won't work right.
>     '(default ((t (:stipple nil :background "black" :foreground "white" 
> :inverse-video nil :box nil :strike-through nil :overline nil :underline nil 
> :slant normal :weight normal :height 90 :width normal :family "dejavu sans 
> mono")))))

> A backtrace shows that it seems to be infinitely recursing in the hairy
> frame/face dance.

> Visually, I can see the Emacs frame continuously re-sizing, and the
> background color continously flipping between black and white.

I see this problem too, and is fixed when I revert this
change.

2008-06-18  Stefan Monnier  <address@hidden>

        * faces.el (face-set-after-frame-default): Don't exclude `default'.

Index: faces.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
retrieving revision 1.409
retrieving revision 1.410
diff -u -r1.409 -r1.410
--- faces.el    13 Jun 2008 02:04:37 -0000      1.409
+++ faces.el    18 Jun 2008 21:14:07 -0000      1.410
@@ -2045,7 +2045,10 @@
     ;; Initialize faces from face specs and X resources.  The
     ;; condition-case prevents invalid specs from causing frame
     ;; creation to fail.
-    (dolist (face (delq 'default (face-list)))
+    (dolist (face (face-list))
+      ;; This loop used to exclude the `default' face for an unknown reason.
+      ;; It lead to odd behaviors where face-spec settings on the `default'
+      ;; face weren't obeyed for new frame.
       (condition-case ()
          (progn
            (face-spec-recalc face frame)

---
Kenichi Handa
address@hidden