Re: underline problem

[David De La Harpe Golden]

Kenichi Handa wrote:

> For the moment, the only solution I can think of is to
> decide the underline position (and thickness) for each frame
> from the default font, and always use it for the frame.
> 
> Any better idea?
> 

Maybe make underline position and thickness a per glyph_row metric?
So that you have a single underline position for each row?

For very varied fonts on the one line with several individual runs of
underlining, that might not be totally ideal, you might prefer
"vertically-ragged" underlining consistent only across contiguous spans
of underlined glyphs, but otherwise the results should be
fairly aesthetically pleasing.

I'm not really familiar with the display code, but maybe
when you're iterating to calculate the overall row [pixel] width, max
ascent/height etc. you could also do a max (or min, whatever the sign
convention is) across the underline position.

i.e. alteration of x_produce_glyphs() and display_line() and struct
glyph_row and it.