Re: grep-mode-map & compilation-minor-mode-map

[Stefan Monnier]

> 1. grep.el uses (cons 'keymap compilation-minor-mode-map) instead of
> more "abstract"
> ~  (let ((map (make-sparse-keymap)))
> ~    (set-keymap-parent map compilation-minor-mode-map)
> is there a specific reason for that?

No.

> 2. is it OK to add these to compilation-minor-mode-map?
> ~  (define-key map "g" 'recompile) ; revert
> ~  (define-key map "q" 'quit-window)
> they appear to be rather standard for non-self-insert buffers and rather
> useful as well.

I'm not sure about these bindings.  Currently, other than RET, this
minor-mode map doesn't bind any of the normal editing keys.
Maybe it'd be better to add them to grep only for now,


        Stefan