[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
23.0.60; hexl-mode-exit doesn't cancel current address eldoc messages
From: |
John Paul Wallington |
Subject: |
23.0.60; hexl-mode-exit doesn't cancel current address eldoc messages |
Date: |
Sat, 26 Apr 2008 02:15:06 +0100 |
User-agent: |
Microsoft Gnus Express, Build 513.230 |
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.
Your bug report will be posted to the address@hidden mailing list.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
Do:
Evaluate (add-hook 'emacs-lisp-mode-hook 'turn-on-eldoc-mode)
then
Visit an Emacs Lisp file
then
M-x hexl-mode
then
C-c C-c (runs hexl-mode-exit)
Bug:
The handy-dandy eldoc-style "current address is blah" hexl-mode messages
still appear.
Suggested Patch:
I can install the following if aren't any objections:
2008-04-26 John Paul Wallington <address@hidden>
* hexl.el (hexl-mode): Stash `eldoc-documentation-function' in
`hexl-mode-old-eldoc-documentation-function'.
(hexl-mode-exit): Restore it.
(hexl-mode-old-eldoc-documentation-function): Declare for compiler.
--- hexl.el.~1.117.~ 2008-02-26 20:16:09.000000000 +0000
+++ hexl.el 2008-03-26 21:05:13.000000000 +0000
@@ -120,6 +120,7 @@
(defvar hexl-mode-old-require-final-newline)
(defvar hexl-mode-old-syntax-table)
(defvar hexl-mode-old-font-lock-keywords)
+(defvar hexl-mode-old-eldoc-documentation-function)
(defvar hexl-ascii-overlay nil
"Overlay used to highlight ASCII element corresponding to current
point.")
@@ -288,6 +289,10 @@
(add-hook 'change-major-mode-hook 'hexl-maybe-dehexlify-buffer nil
t)
;; Set a callback function for eldoc.
+ (make-local-variable 'hexl-mode-old-eldoc-documentation-function)
+ (setq hexl-mode-old-eldoc-documentation-function
+ (bound-and-true-p eldoc-documentation-function))
+
(set (make-local-variable 'eldoc-documentation-function)
'hexl-print-current-point-info)
(eldoc-add-command-completions "hexl-")
@@ -405,6 +410,10 @@
(when (boundp 'hexl-mode-old-hl-line-face)
(setq hl-line-face hexl-mode-old-hl-line-face))
+ (when (boundp 'hexl-mode-old-eldoc-documentation-function)
+ (setq eldoc-documentation-function
+ hexl-mode-old-eldoc-documentation-function))
+
(setq require-final-newline hexl-mode-old-require-final-newline)
(setq mode-name hexl-mode-old-mode-name)
(setq isearch-search-fun-function hexl-mode-old-isearch-search-fun-function)
If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Users/jpw/src/emacs/etc/DEBUG for instructions.
In GNU Emacs 23.0.60.1 (i386-apple-darwin9.2.2)
of 2008-04-25 on mini.home
configured using `configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no'
'--without-x''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: nil
default-enable-multibyte-characters: t
Major mode: Emacs-Lisp
Minor modes in effect:
eldoc-mode: t
show-paren-mode: t
delete-selection-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
[elided]
Recent messages:
[elided]
- 23.0.60; hexl-mode-exit doesn't cancel current address eldoc messages,
John Paul Wallington <=