vc.el and CSSC

[Ulrich Mueller]

Hi,

while applying and testing the recent security fix for lib-src/vcdiff
(CVE-2008-1694), I've noticed that vc does not work with GNU CSSC.

The vcdiff script doesn't find the "get" command which CSSC installs
in /usr/libexec/cssc/:

/usr/libexec/emacs/22.2/i686-pc-linux-gnu/vcdiff: line 88: get: command not 
found

Also, commands like vc-sccs-checkout don't work because they don't
find "get" in PATH.

The patch included below (for CVS trunk) should fix it. However, I did
only some basic testing (checkout, checkin, diff).

Ulrich


--- lib-src/vcdiff      19 Apr 2008 10:11:34 +0200      1.17
+++ lib-src/vcdiff      19 Apr 2008 17:53:59 +0200      
@@ -27,7 +27,8 @@
 DIFF="diff"
 usage="$0: Usage: vcdiff [--brief] [-q] [-r<sid1>] [-r<sid2>] [diffopts] 
sccsfile..."
 
-PATH=$PATH:/usr/ccs/bin:/usr/sccs:/usr/xpg4/bin # common SCCS hangouts
+# common SCCS hangouts
+PATH=$PATH:/usr/libexec/cssc:/usr/ccs/bin:/usr/sccs:/usr/xpg4/bin
 
 echo="echo"
 sid1= sid2=
--- lisp/vc-hooks.el    19 Apr 2008 10:11:35 +0200      1.238
+++ lisp/vc-hooks.el    19 Apr 2008 17:55:59 +0200      
@@ -85,9 +85,11 @@
   :group 'vc)
 
 (defcustom vc-path
-  (if (file-directory-p "/usr/sccs")
-      '("/usr/sccs")
-    nil)
+  (append
+   (if (file-directory-p "/usr/libexec/cssc")
+       '("/usr/libexec/cssc"))
+   (if (file-directory-p "/usr/sccs")
+       '("/usr/sccs")))
   "List of extra directories to search for version control commands."
   :type '(repeat directory)
   :group 'vc)