emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bookmark.el and lisp/gnus/gnus-bookmark.el


From: Bastien
Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el
Date: Sat, 08 Mar 2008 01:31:38 +0000
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> (defun bookmark-make-record-for-text-file (annotation &optional name)
>>    "Return the record.  
>> If optional arg NAME is non-nil, just return the default name for
>> this bookmark."
>>    ...)
>
>> I think it's easier.  Each mode should have to worry about one
>> buffer-local variable (and each dev would only read one docstring...)
>
> This might work, tho I'd throw away the `name' arg.  Let the
> buffer-local function build a bookmark record (i.e. a cons cell of the
> form (NAME . ALIST)) with any name it chooses, and then change the name
> according to the user's choice.  I.e. make the bookmark record before
> even prompting the user for a name.

Following Karl advice I've applied a different patch.  There is now
`bookmark-make-name-function' *and* `bookmark-make-record-function',
both buffer local.  For an example on how this is supposed to work 
look at the changes I've made in info.el.  

I think it's okay like this.  If you plan to change anything please 
tell me before I work on gnus-bookmark.el. 

Thanks,

-- 
Bastien




reply via email to

[Prev in Thread] Current Thread [Next in Thread]