PCL-CVS menu enhancements

[Reiner Steib]

Hi,

I'd like to propose some minor enhancements to PCL-CVS's menu (full
patch attached below).

|  (easy-menu-define cvs-menu cvs-mode-map "Menu used in `cvs-mode'."
|    '("CVS"
| -    ["Open file.."           cvs-mode-find-file      t]
| -    [" ..other window"               cvs-mode-find-file-other-window t]
| +    ["Open file..."          cvs-mode-find-file      t]
| +    ["  ...in other window"  cvs-mode-find-file-other-window t]
|      ["Display in other window"  cvs-mode-display-file   t]
|      ["Interactive merge"     cvs-mode-imerge         t]

At least for "Open file", the convention is to have three dots, isn't
it?

Or better like this?

    ["Open file..."             cvs-mode-find-file      t]
    ["Open in other window"     cvs-mode-find-file-other-window t]

|       ["Current diff"         cvs-mode-diff           t]
|       ["Diff with head"               cvs-mode-diff-head      t]
|       ["Diff with vendor"     cvs-mode-diff-vendor    t]
| +     ["Diff against yesterday"       cvs-mode-diff-yesterday t]
|       ["Diff with backup"     cvs-mode-diff-backup    t])

Why omit `cvs-mode-diff-yesterday'?

|      ["Hide handled"          cvs-mode-remove-handled t]
|      "----"
| +    ["PCL-CVS Manual"                (lambda () (interactive)
| +                               (info "(pcl-cvs)Top")) t]
| +    "----"
|      ["Quit"                  cvs-mode-quit           t]))

Users might look in the Emacs manual first.  This should make it
easier to find the right manual.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

--- pcvs-defs.el        09 Jan 2008 20:35:45 +0100      1.44
+++ pcvs-defs.el        20 Jan 2008 21:25:28 +0100      
@@ -404,8 +404,8 @@
 
 (easy-menu-define cvs-menu cvs-mode-map "Menu used in `cvs-mode'."
   '("CVS"
-    ["Open file.."             cvs-mode-find-file      t]
-    [" ..other window"         cvs-mode-find-file-other-window t]
+    ["Open file..."            cvs-mode-find-file      t]
+    ["  ...in other window"    cvs-mode-find-file-other-window t]
     ["Display in other window"  cvs-mode-display-file   t]
     ["Interactive merge"       cvs-mode-imerge         t]
     ("View diff"
@@ -413,6 +413,7 @@
      ["Current diff"           cvs-mode-diff           t]
      ["Diff with head"         cvs-mode-diff-head      t]
      ["Diff with vendor"       cvs-mode-diff-vendor    t]
+     ["Diff against yesterday" cvs-mode-diff-yesterday t]
      ["Diff with backup"       cvs-mode-diff-backup    t])
     ["View log"                        cvs-mode-log            t]
     ["View status"             cvs-mode-status         t]
@@ -437,6 +438,9 @@
     ["Unmark all"              cvs-mode-unmark-all-files t]
     ["Hide handled"            cvs-mode-remove-handled t]
     "----"
+    ["PCL-CVS Manual"          (lambda () (interactive)
+                                 (info "(pcl-cvs)Top")) t]
+    "----"
     ["Quit"                    cvs-mode-quit           t]))
 
 ;;;;