emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: finish version test cleanup: Lucid


From: Vinicius Jose Latorre
Subject: Re: finish version test cleanup: Lucid
Date: Sun, 28 Oct 2007 17:11:11 -0300
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071009 SeaMonkey/1.1.5

Dan Nicolaescu wrote:
Most string version tests have been replaced with feature tests. These are the remaining ones:

./progmodes/cperl-mode.el:81:      (defconst cperl-xemacs-p (string-match 
"XEmacs\\|Lucid" emacs-version))
./progmodes/cperl-mode.el:154:(defconst cperl-xemacs-p (string-match 
"XEmacs\\|Lucid" emacs-version))
./ielm.el:172:  (if (string-match "Lucid" emacs-version)
./ps-print.el:1467: ((string-match "Lucid" emacs-version)
./ps-print.el:1469: ((string-match "Epoch" emacs-version)
./calc/calc.el:825:(defvar calc-emacs-type-lucid (not (not (string-match 
"Lucid" emacs-version))))
./emulation/tpu-mapper.el:83:(defconst tpu-lucid-emacs19-p (string-match 
"Lucid" emacs-version)

Can these tests be replaced with feature tests?

AFAIK, there isn't any feature test for Lucid and Epoch.

Can these tests be eliminated?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]