Re: doc-view compilation warnings

[Tassilo Horn]

Stefan Monnier <address@hidden> writes:

Hi Stefan,

>>> > +(push '("\\.[eE]?[pP][sS]\\'" . doc-view-mode-maybe) auto-mode-alist)
>>> > +(push '("\\.[Dd][Vv][Ii]\\'"  . doc-view-mode-maybe) auto-mode-alist)
>>> > +(push '("\\.[Pp][Dd][Ff]\\'"  . doc-view-mode-maybe) auto-mode-alist)
>>> 
>>> In general loading a file should not have side effects like this. 
>>> IMHO, it is not idea to do things this way...
>
>> So what would you suggest?  A function `doc-view-initialize' that
>> does this?
>
> You could put it directly into files.el.

That would load doc-view unconditionally when a user opens a pdf/ps/dvi
file.  That's ok with me, but others might think different.

But someone should decide: Is loading doc-view when opening ps/pdf/dvi
files ok?

> Or (tho less good) put it into `doc-view-mode' (so loading the file
> doesn't have any side-effect, though using doc-view does).

But then a user would need to open a document and enable d-v-m manually
in order to have it (or its minor mode) activated automatically when
opening another doc.

IMO a setup function would be better then.

Bye,
Tassilo