[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: New VC mode -- review request
From: |
Eric S. Raymond |
Subject: |
Re: New VC mode -- review request |
Date: |
Tue, 9 Oct 2007 13:21:03 -0400 |
User-agent: |
Mutt/1.5.15+20070412 (2007-04-11) |
Dan Nicolaescu <address@hidden>:
> > That's correct, because the visited file isn't under version control.
>
> That would be a change in long standing behavior, and it is
> inconsistent with with to docstring for vc-next-action: " If every
> file is not already registered, this registers each one for version
> control. This does an add, but not a commit."
> IMO this behavior is one of the strengths of vc: C-x v v always does TRT.
Actually, I agree with you -- that's how I originally wrote C-x v v, and
with that DTRT intention. But somebody broke that feature of vc-next-action
years ago, and I've been trying to be very conservative about not
bundling into new VC behavioral changes that weren't directly related
to the fileset stuff.
> Sure, just let's make sure it does not get forgotten.
Since it's the way I originally wanted the mode to work, it won't be :-)
> Another post merge issue:
> The code that deals with registering in vc-next-action:
> ;; Files aren't registered
> ((not state)
> (mapc 'vc-register files))
>
> Maybe vc-register could work on a list of files? vc-BACKEND-register
> already does that..
Noted. I'll start keeping a to-do list.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
- New VC mode -- review request, Eric S. Raymond, 2007/10/03
- Re: New VC mode -- review request, Dan Nicolaescu, 2007/10/03
- Re: New VC mode -- review request, Eric S. Raymond, 2007/10/03
- Re: New VC mode -- review request, Dan Nicolaescu, 2007/10/03
- Re: New VC mode -- review request, Eric S. Raymond, 2007/10/03
- Re: New VC mode -- review request, Dan Nicolaescu, 2007/10/03
- Re: New VC mode -- review request, Eric S. Raymond, 2007/10/09
- Re: New VC mode -- review request, Dan Nicolaescu, 2007/10/09
- Re: New VC mode -- review request,
Eric S. Raymond <=
- Re: New VC mode -- review request, Thien-Thi Nguyen, 2007/10/04
Re: New VC mode -- review request, Alexandru Harsanyi, 2007/10/03
Re: New VC mode -- review request, Richard Stallman, 2007/10/04
Re: New VC mode -- review request, David Kastrup, 2007/10/04
Re: New VC mode -- review request, Richard Stallman, 2007/10/03