Re: New VC diff for review

[Stefan Monnier]

>> One of these vc-diff* functions needs to do (vc-call
>> revision-completion-table file) like vc-version-diff does in order to get
>> completions for versions.

> There's a conceptual problem here.  Remember that new VC operates on
> filesets, not files.  If the fileset has more than one member, which file
> should be used  to key into the revision completion table?

What's the problem: pass it the fileset and let the backend decide.
 
>> -                                        (expand-file-name f odefault)))
>> +                                        (if (file-name-absolute-p f)
>> +                                            f
>> +                                          (concat odefault f))))
>> files)))
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> Is this change intentional or a merge problem? It's hard to tell...

Merge problem.  I "recently" replaced the `if' form by the simpler
`expand-file-name' call.


        Stefan