[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: SVG support(again) ?
From: |
Richard Stallman |
Subject: |
Re: SVG support(again) ? |
Date: |
Thu, 16 Aug 2007 20:32:00 -0400 |
/* Structure describing the image type `svg'. */
static struct image_type svg_type =
{
&Qsvg,
svg_image_p,
svg_load,
x_clear_image,
NULL
};
How about adding another comment for each field explaining what
the field means and why this particular value is used.
/* DEF_IMGLIB_FN() here? */
I don't understand that comment -- if you do, could you make
it less terse, and clear?
/* helper function for svg_load, does the actual loading
given contents and size, apart from frame and image structures, passed
from svg_load
Uses librsvg to do most of the image processing.
Returns non-zero when sucessful
*/
That is terse and cryptic. Could you rewrite it to be clear
and format it the way we like to do?
The code of svg_load_image needs more comments explaining what the
parts of the code do.
- Re: SVG support(again) ?, (continued)
- Re: SVG support(again) ?, joakim, 2007/08/09
- Re: SVG support(again) ?, Richard Stallman, 2007/08/11
- Re: SVG support(again) ?, joakim, 2007/08/14
- Re: SVG support(again) ?, Richard Stallman, 2007/08/14
- Re: SVG support(again) ?, Mathias Dahl, 2007/08/15
- Re: SVG support(again) ?, joakim, 2007/08/16
- Re: SVG support(again) ?,
Richard Stallman <=
- Re: SVG support(again) ?, joakim, 2007/08/18
- Re: SVG support(again) ?, Richard Stallman, 2007/08/18
- Re: SVG support(again) ?, joakim, 2007/08/19
- Re: SVG support(again) ?, Richard Stallman, 2007/08/19
- Re: SVG support(again) ?, joakim, 2007/08/20
- Re: SVG support(again) ?, Richard Stallman, 2007/08/21
- Re: SVG support(again) ?, joakim, 2007/08/21
- Re: SVG support(again) ?, Glenn Morris, 2007/08/22
- Re: SVG support(again) ?, joakim, 2007/08/22
- svn icons in the toolbar (was: SVG support(again) ?), Leo, 2007/08/29