emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Forward button for help buffer


From: martin rudalics
Subject: Re: [PATCH] Forward button for help buffer
Date: Mon, 11 Jun 2007 08:50:44 +0200
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

The forward buttons are nice, thanks.  One minor nitpick: When there's
only a forward-button and no back-button there's no newline before the
forward-button.  Please consider something like the attached patch.
*** help-mode.el        Sun Jun 10 17:46:38 2007
--- help-mode.el        Mon Jun 11 08:44:02 2007
***************
*** 500,515 ****
        (while (and (not (bobp)) (bolp))
          (delete-char -1))
          (insert "\n")
          ;; Make a back-reference in this buffer if appropriate.
          (when help-xref-stack
-         (insert "\n")
          (help-insert-xref-button help-back-label 'help-back
!                                  (current-buffer))
!           (insert "\t"))
          ;; Make a forward-reference in this buffer if appropriate.
          (when help-xref-forward-stack
          (help-insert-xref-button help-forward-label 'help-forward
!                                  (current-buffer))
            (insert "\n")))
        ;; View mode steals RET from us.
        (set (make-local-variable 'minor-mode-overriding-map-alist)
--- 500,518 ----
        (while (and (not (bobp)) (bolp))
          (delete-char -1))
          (insert "\n")
+       (when (or help-xref-stack help-xref-forward-stack)
+           (insert "\n"))
          ;; Make a back-reference in this buffer if appropriate.
          (when help-xref-stack
          (help-insert-xref-button help-back-label 'help-back
!                                  (current-buffer)))
          ;; Make a forward-reference in this buffer if appropriate.
          (when help-xref-forward-stack
+         (when help-xref-stack
+           (insert "\t"))
          (help-insert-xref-button help-forward-label 'help-forward
!                                  (current-buffer)))
!       (when (or help-xref-stack help-xref-forward-stack)
            (insert "\n")))
        ;; View mode steals RET from us.
        (set (make-local-variable 'minor-mode-overriding-map-alist)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]